DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

[redis-ha] Update README.md #183

Closed alexandru-postolache closed 2 years ago

alexandru-postolache commented 2 years ago

Add the splitBrainDetection resources field. This is a mandatory field. I did an update from the 4.5.7 version to 4.14.9 and it complained for missing resources on the split brain detection container and it worked after I added it.

What this PR does / why we need it:

It shows in the README file that the resource field of the splitBrainDetection is needed.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

alexandru-postolache commented 2 years ago

can you have a look at this ?

DandyDeveloper commented 2 years ago

That's odd, it's plausible this is more Kubernetes version specific. I haven't had the same issue, but I'm lagging behind on my k8s versions.

Should be included though. Thank you.