search

DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

[charts/redis-ha] Deploy HAProxy config in IPv4/IPv6 mode #186

Closed archoversight closed 2 years ago

archoversight commented 2 years ago

Instead of listening only on IPv4, this updates the configuration to start an IPv6 socket that also accepts connections over IPv4 using the v4v6 flag from http://cbonte.github.io/haproxy-dconv/2.5/configuration.html#5.1-v4v6

This allows clusters that are in IPv6 only mode (for example, an EKS cluster) to bring up an HA redis correctly.

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

This requires that we bind to [::] with the v4v6 flag which will create a socket that can accept both IPv4 and IPv6. The other solution is to explicitly bind to both by adding two bind statements instead.

Without this change the HA Proxy systems would continue to fail over and over.

Checklist

DandyDeveloper commented 2 years ago

Getting this in! Sorry @archoversight I've been busy changing jobs and life took over.

borislitv commented 2 years ago

https://github.com/DandyDeveloper/charts/blob/master/charts/redis-ha/templates/_configs.tpl#L79 hi, this regex for ipv4 only, this pr not working with ipv6only configuration.