DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

[chart/redis-ha][REQUEST] use fullname template in test container name #227

Open elchenberg opened 2 years ago

elchenberg commented 2 years ago

This is a non-issue but if you are open to it I would be happy to open a pull request. :slightly_smiling_face:

Is your feature request related to a problem? Please describe.

The name of the test container uses .Release.Name and not template "redis-ha.fullname". When I install the redis-ha chart as a dependency of a different chart, for example "trivy", the name of the container changes from "redis-ha-service-test" to "trivy-service-test" (wich might be confusing).

Describe the solution you'd like

template "redis-ha.fullname" is used for the container name.

Describe alternatives you've considered

Additional context Add any other context or screenshots about the feature request here.

DandyDeveloper commented 2 years ago

@elchenberg On it, might take a couple of days as I have limited PC time. Very quick change and makes sense.