search

DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

Allow setting annotations on Pods in StatefulSet #233

Closed silvpol closed 1 year ago

silvpol commented 1 year ago

Currently there is no way to set custom annotations on pods in the StatefulSet for Redis server, only on the StatefulSet itself. In our use case this prevents setting Cluster Autoscaler annotation causing scaling down to block. The annotation (cluster-autoscaler.kubernetes.io/safe-to-evict: true) is needed for recent K8s versions due to local storage being utitlised. I think there are more use cases for this as well. HAProxy deployment already offers this option so this functionality would complement it nicely.

DandyDeveloper commented 1 year ago

@silvpol Sorry for the delay: https://github.com/dandydeveloper/charts/blob/169cad792a9193844990ac6b355f7b27b607d6fb/charts/redis-ha/templates/redis-ha-statefulset.yaml#L32

.Values.podAnnotations exists? Isn't this what you're asking for?

silvpol commented 1 year ago

@DandyDeveloper thanks, I only looked in README, sorry about that. I found it in chart and it works as expected.