[charts/redis-ha] Add extraAnnotations value allowing to add annotations for every sing…

DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation

https://dandydeveloper.github.io/charts

Apache License 2.0

157 stars 145 forks source link

[charts/redis-ha] Add extraAnnotations value allowing to add annotations for every sing… #234

Closed imvalient closed 1 week ago

imvalient commented 2 years ago

…le resource generate, from a single value declaration

What this PR does / why we need it:

I've been using this chart for a long time. Right now, I'm trying to add a custom annotation to all the resources generated by this chart, but currently, it's not supported. This PR enables this feature.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

DandyDeveloper commented 1 year ago

LGTM, sorry for this taking so long. Merging when it passes.

DandyDeveloper commented 1 year ago

@imvalient Looks like the CI sees some problems. Possibly indentation? Can you triple check your work here?

imvalient commented 1 year ago

@DandyDeveloper thanks, it should be fixed now.

imvalient commented 1 year ago

@DandyDeveloper, I think that you have to approve the needed GitHub actions, right?

DandyDeveloper commented 1 year ago

@imvalient I actually think GH ACtions was having problems the other day... Going to do what I can to get these running.

DandyDeveloper commented 1 year ago

@imvalient Looks like its still broken. FYI: Do some local helm template . or helm install with and without the annotations. It should show the same as what we're seeing in the CI.