When you run Redis with TLS with authClients set to "no", the fix-split-brain sidecar does not talk to Redis or Sentinel over TLS.
authClientsonly configures whether or not mutual TLS is required therefore moving the --tls --cacert arguments out of the conditional checking authClients fixes this issue.
Also updated the TLS_CLIENT_OPTION so that --cert and --key are only used if client authentication is required.
What this PR does / why we need it:
When you run Redis with TLS with
authClients
set to "no", the fix-split-brain sidecar does not talk to Redis or Sentinel over TLS.authClients
only configures whether or not mutual TLS is required therefore moving the--tls --cacert
arguments out of the conditional checkingauthClients
fixes this issue.Also updated the
TLS_CLIENT_OPTION
so that--cert
and--key
are only used if client authentication is required.Example Helm values snippet
```yaml redis: port: 0 tlsPort: 6385 tlsReplication: true authClients: "no" sentinel: # Disable non-TLS port port: 0 tlsPort: 26385 tlsReplication: true authClients: "no" tls: secretName: cert-redis certFile: tls.crt keyFile: tls.key caCertFile: ca.crt ```Which issue this PR fixes
Didn't raise an issue, though I can if it helps.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)