[charts/redis-ha] Remove HAproxy revision label - Githubissues

DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation

https://dandydeveloper.github.io/charts

Apache License 2.0

156 stars 143 forks source link

[charts/redis-ha] Remove HAproxy revision label #241

Closed pando85 closed 1 year ago

pando85 commented 1 year ago

What this PR does / why we need it:

Where this label come from: DandyDeveloper/charts#6

This label causes two main problems for us:

helm-diff plugin is not working correctly
all changes on a chart that uses redis-ha as dependency triggers a redeployment of HAproxy pods.

If we reduce number of replicas to 2 in HAproxy we can allow clusters of 3 nodes upgrade without having any of this issues.

Another option in that case can be just to disable hardAntiAffinity.

Which issue this PR fixes

fixes #189

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

DandyDeveloper commented 1 year ago

Going to keep the replicas to 3 for now on the defaults, the rest I'm absolutely happy with. Waiting on CI before merging.