DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

[chart/redis-ha]support configuration for redis container command parameter #254

Open GDegrove opened 1 year ago

GDegrove commented 1 year ago

Is your feature request related to a problem? Please describe.

I'm trying to deploy redis-ha using redis-stack-server as the image.

From what I can see, the current helm chart only start the container with redis-server. However, when using the redis-stack-server you want to start the contianer with /entrypoint.sh (don't know why the startup script is name entrypoint though...) or using the redis-stack-server.

Describe the solution you'd like

Add a configuration for the helm chart to contain a way to override/configure the command. Instead of using the hard-coded edis-server, we may want to let user chose. This would allow a developer to easily change the configuration of the helm chart without spending too much time on making sure their image is compatible with it.

Describe alternatives you've considered

GDegrove commented 1 year ago

seems that would be resolved by #238

DandyDeveloper commented 7 months ago

Yes. #238 would do this, it was neglected. I'll re-review to see if this is definitely fit for purpose and try to get this merged in.