DandyDeveloper / charts

Various helm charts migrated from [helm/stable] due to deprecation
https://dandydeveloper.github.io/charts
Apache License 2.0
156 stars 143 forks source link

redis-ha: fix busybox-ash-ism in redis_liveness.sh #294

Closed bootc closed 1 month ago

bootc commented 1 month ago

What this PR does / why we need it:

The ${response:0:7} syntax is non-POSIX and not understood by Debian's dash shell, so if a Debian-based Redis image is used the liveness check breaks on slaves. A case statement makes this check more legible anyway, in my opinion, and works in all the POSIX-compatible shells (busybox ash, dash, and bash).

Which issue this PR fixes

No issue created (yet).

Checklist

DandyDeveloper commented 1 month ago

@bootc Waiting on a separate PR to merge and I'll edit the chart patch to get the latest pushed out. Thank you!