search

DandyLyons / React-Example

An example of a React app written in TypeScript, using Vite.
MIT License
2 stars 3 forks source link

[FEATURE] Create favicon #1

Closed DandyLyons closed 11 months ago

DandyLyons commented 1 year ago

Requirements

DandyLyons commented 12 months ago

The React app needs a favicon.

https://www.geeksforgeeks.org/how-to-change-the-favicon-in-react-js/

x5401 commented 11 months ago

Hi, I'd like to work on this issue, thanks!

DandyLyons commented 11 months ago

Hi Pai, thank you for showing interest. I'd like to get you paired with another classmate so that you/I/we all can get practice pair programming. Dan and Destiny both shared interest in working on an Issue (but they haven't yet commented on an Issue on GitHub). I'd like to pair you with one of them.

If they don't communicate by Wed. then I'll go ahead and assign this to you. (Another option is you can pair with me.)

(btw, both people in a pair will be given credit for the contribution.)

DandyLyons commented 11 months ago

Hi @Amandaan , Dan messaged me on Slack that she'd like to work on this Issue with you. After Dan comments here on this thread, I'll assign her to this Issue as well (so then you'll both be assigned to it).

Both of you, please download the official Live Share VS Code Extension. Hopefully this should help make pair programming much easier.

Here's detailed instructions about how to use it. https://code.visualstudio.com/learn/collaboration/live-share

DanWang625 commented 11 months ago

Hi Daniel, I'd like to work on this issue with Pai, thank you.

DandyLyons commented 11 months ago

I'm excited to see the work you two do! Please let me know if you get stuck anywhere. I would love to help out however I can.

DanWang625 commented 11 months ago

Thank you so much, we'll try our very best

DandyLyons commented 11 months ago

I'm reposting what @Amandaan sent me on Slack so that we can all be looped in on the conversation here. Here's her message.

Screenshot 2023-11-03 at 11 47 13 AM

My response

Great job you two! 🚀 It looks like you successfully pushed your change to your repository. The next step is to make what's called a Pull Request. (A Pull Request in GitHub, is analogous to what GitLab calls a merge request). A Pull Request is a vital skill that will be used on virtually any collaborative project, so it's fantastic that we're getting practice on one right now.

Here's a tutorial on Pull Request's: https://www.youtube.com/watch?v=8lGpZkjnkt4&pp=ygUMcHVsbCByZXF1ZXN0 And here's a tutorial on writing a quality PR: https://github.blog/2015-01-21-how-to-write-the-perfect-pull-request/

It looks like the next step is for you to click the Compare & Pull Request button on GitHub. The step after that is very crucial. You want to make sure that you are clearly and concisely communicating the changes you made in your PR and why you made them. This will make it easier for me to review your changes.

When I review the PR, I might ask for some changes. If so, this is completely normal, and is a part of the process. After I approve of the changes, then I'll merge the PR and it'll be a success. 🎉

P.S. Sorry, I did an example of not-so-great communication! 😅 When I opened this GitHub Issue, I didn't actually include the requirements in the Issue. I've added them now. Please have a look at them at the top of this Issue thread. (They're short.)

x5401 commented 11 months ago

Thank you Daniel! We have created a pull request

DandyLyons commented 11 months ago

https://github.com/DandyLyons/React-Example/pull/14

DandyLyons commented 11 months ago

Great job! Go to the PR to see my comments.