Open DandyLyons opened 11 months ago
Hi Daniel, Pai and I want to do this one, if this issue was not assigned to anybody else yet.
Fantastic! I've assigned you. Unfortunately, it seems like GitHub won't allow me to assign Pai unless she comments here as well.
Thank you, Daniel, I'll let Pai know.
Hi Daniel! I'd like to work on this issue with Dan, thanks!
Hi, Daniel, we got some errors when we try to push, can't figure out what the problem is, please find details attached below
Sure, let's troubleshoot.
I noticed that when you called git push origin 8123-fix-issue8
it says you don't have permission to push to DandyLyons/React-Example.git
. That would make sense. You should be pushing to your GitHub repo, not mine. (After you push to yours, then you create a PR on GitHub).
So if I'm not mistaken, you should set your upstream to be your repo on your GitHub. (You choose which branch, I usually use dev
or main
).
The question is did you clone from your fork, or did you clone directly from my GH repo? You should have cloned from your GH repo. (Either way, we should be able to fix this).
What do you see when you call git remote -v
?
Good troubleshooting, Daniel, you're right, I cloned from yours, that's the problem. I'll reclone from mine. When I call git remote -v, it shows this:
you're totally right.
Fantastic work, you two!
Please see the review that I added: https://github.com/DandyLyons/React-Example/pull/15#pullrequestreview-1725166111
On another note, I would like to ask you two, how was pair programming? How can we improve our process to make everything easier and more enjoyable for everyone?
Were you able to get the VS Code Live Share plugin to work?
How was working with Figma?
How was working with GitHub (in Issues, Pull Requests etc.)
Good troubleshooting, Daniel, you're right, I cloned from yours, that's the problem. I'll reclone from mine. When I call git remote -v, it shows this: you're totally right.
In the future, there is a way to re-setup the upstream repository. This way you don't have to reclone the repo (and thus lose all your work). If I remember correctly the steps would be:
git remote add <name> <url>
where:
git push -u <repo name>
Thank you so much, learned so much from you
Navigation
ComponentWe'll be making a
Navigation
Component. Please comment with any questions you have.If you would like to be assigned to this Issue please comment below.
User Story:
As a user, I want to navigate between so that I can find what I'm looking for.
Description:
Navigation Bar
Acceptance Criteria:
Navigation.tsx
in thesrc
directory.Design Mockup/Assets:
Go to this link: Navigation Component Design in Figma
Additional Information:
Priority:
High
Linked Issues/PRs:
Due Date:
Try to complete this before mid-November.