search

Danfoa / invite-robotics

Integration of Motoman CSDA10f dual arm robot with ROS, Moveit and Gazebo, with aims of creating a robotics developing platform for Invite GmbH, pre-configured to be simple to use and learn.
MIT License
56 stars 21 forks source link

Add objects by code #3

Closed HalejoAS closed 6 years ago

Danfoa commented 6 years ago

Could you please see the comments I've made on the Objects.cpp executable, there is a general lack of comments explaining what and how are you doing things, and some things that should not be there.

Danfoa commented 6 years ago

By the way with the inclusion is the mesh already being considered for collision avoidance? What if want to grasp it, and need to disable temporally the collision checking for this mesh?

Danfoa commented 6 years ago

This is a malformed PR, you should rebase with the current state of developmental branch and only commit what you have changed.

Do not do 

git add --all

do

git add <File you changed>