Dangabit / pe

0 stars 0 forks source link

Linking with the same crew for the same position for flight overwrites #9

Open Dangabit opened 1 year ago

Dangabit commented 1 year ago

Initially, I have "Test" as my CSD

image.png

On execution of linkflight /fl 1 /csd 1, I can overwrite that position.

image.png

This is an unexpected response for this command. (This also applies for pilots)

nus-se-bot commented 1 year ago

Team's Response

This is by design. The reason is that there could only be one role in that position. If you were to assign someone new to that position, then that position should be replaced by the newly assigned person.

If we look at the code, we have two different put methods. One if put, which would throw an exception if the link is full (if there is already someone there), and it would be reflected to the user. The other is putRevolve, which would simply replace the old one. We feel that the most intuitive way for us to implement this is though the use of put and replace.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]