DangerKlippers / danger-klipper

Klipper but... Dangerous
GNU General Public License v3.0
255 stars 83 forks source link

Trust the user on the print_radius for delta kinematics #384

Closed CarpeNecopinum closed 1 month ago

CarpeNecopinum commented 1 month ago

In current versions of (danger)-klipper, the configured print_radius on a delta printer is just silently ignored when it's larger than arm_length - delta_radius.

While points beyond that radius might not be useful for actual print moves, I have a klicky-style probe that I want the printer to pick up outside of the "reasonable" build volume, which was formerly prevented by the above issue.

I tested the committed code on my delta printer and it solves my issue. Additionally I actively tried running it into "unreachable" territory (i.e. to the point where one of the arms would have to be horizontal and the stepper moving at infinite speed, and beyond) and found that klipper safely shuts down, without excessive movement etc.

Checklist

rogerlz commented 1 month ago

thanks! It is an interesting one because the documentation even says that a larger number in this parameter would allow a move command to collide with the towers

If a large value is specified here then it may be possible to command the toolhead into a collision with a tower. The default is to use delta_radius for print_radius (which would normally prevent a tower collision)