DangerousPrototypes / BusPirate5-firmware

Bus Pirate v5 Firmware
MIT License
136 stars 42 forks source link

DRAFT - DO NOT MERGE - Add third USB CDC (COM) port for debug output #93

Closed henrygab closed 3 weeks ago

henrygab commented 1 month ago

For discussion of the feature, review as it is developed, etc.

N.B. - This branch is NOT intended to be merged directly. It has too many changes. Small commits at each step, but still ... too much for one PR. Besides, the second time it's written, things are done more cleanly. :wink:


Log

* When I first tried to expose the new COM port (commit titled, "Maybe this adds...", zero COM ports appeared in Windows. This was likely because I misunderstood how to define the count of each interface that is needed in `tusb_config.h`. Need to re-test to see if this was the primary cause. * Filed two issues for tracking purposes that likely need trivial changes to the Makefile. See issue #91 and issue #92. * USB Descriptor indicates power usage of only `100mA`. Not sure if that's OK, so opened new issue #94 to get input and awareness. * May have found a deadlock when using `printf` and the like from Core1. May have also found a solution. See new issue #97. * Got concerned about the use of unsafe `sprintf`. Manually calculated worst-case buffer usage for status bar. `ui_statusbar_update()` theoretically could write `1492` bytes into the buffer ... which is only `1024` bytes in size. Conversion to use safe string functions is **_strongly recommended_**. See new issue #98. * That raised awareness of a common experience for programs supporting multiple translations. Users may be presented with UI in a default language, and have trouble selecting their native / preferred language. See new issue #96.