search

DaniAsh551 / wemod-launcher

Tool made to launch the popular Game Trainer / Cheat tool WeMod along with your game (made for steam-runtime version in Linux).
MIT License
174 stars 8 forks source link

[WIP - DO NOT USE] Pythonic and simpler refactor of `wemod-launcher` #105

Open shymega opened 2 months ago

shymega commented 2 months ago

Hi all!

As mentioned briefly in #100, and discussed over Discord with Marvin, this PR is a overhaul I'm working on of wemod-launcher.

Testing is welcome once I get to a stage where it can be tested.

However, right now - it's a heavy WIP, and should not be used.

I have marked it as a draft PR.

It's worth noting that Nix is able to build this package on this PR natively, so that is very cool.

Contributions welcome to my fork as PRs, which will then be pushed to this PR.

(Note: I will be rebasing and force-pushing. Let me know in advance before you push to this branch if you're a maintainer, as your changes may be lost.)

Thank you!

marvin1099 commented 2 months ago

In general keep in mind by refactoring this, you are also then responsible for this code, the thing is the fact you are making is nice, but my coding skills are not close to yours, therefore I only somewhat understand your code, but since somewhat wont be enough to fix all bugs the new code is your responsibility.

Just keep that in mind.

shymega commented 2 months ago

In general keep in mind by refactoring this, you are also then responsible for this code, the thing is the fact you are making is nice, but my coding skills are not close to yours, therefore I only somewhat understand your code, but since somewhat wont be enough to fix all bugs the new code is your responsibility.

Just keep that in mind.

Understood. I'll be contributing a Nix package upstream too, and as I use WeMod on my gaming sessions - this project is a motivation.