search

DaniGuardiola / agario-ninja

3 stars 4 forks source link

Broken today? #3

Open jez9999 opened 9 years ago

jez9999 commented 9 years ago

Today agar.io seems to have broken agario-ninja. When WASD is enabled, the keyboard and the mouse will control the cell movement (mouse control is no longer disabled for some reason). Please fix!

DaniGuardiola commented 9 years ago

It works for me. Are you sure you enabled the extension by clicking the toggle button on the top left corner?

jez9999 commented 9 years ago

To be honest I'm not sure how that toggle is even meant to work. I mean you have that, and then you have the spacebar as well? How do those toggles work together?

Really, I wish you would get rid of that toggle altogether. If I didn't want keyboard control, why would I have your extension installed?

DaniGuardiola commented 9 years ago

My extension has a set of features including click or O/P to shoot / divide, keyboard keys for changing settings and will get more features in a future. The toggle enables / disables all of these features, the space switches between WASD / arrows and mouse to move.

I should make it clearer in the future though. Thanks for your feedback.

jez9999 commented 9 years ago

What I suggest is putting all these settings in a new tab, rather than using space to toggle or having a toggle control in the corner. It would be much cleaner and a nice separation of the settings from the actual agar.io page.

DaniGuardiola commented 9 years ago

I don't like the idea of opening a new tab, but I may put a small settings window under a button to configure the extension

jez9999 commented 9 years ago

A button on the agar.io page? The trouble is you're still obscuring part of the page, which isn't great.

jez9999 commented 9 years ago

I think I found the cause of the breakage - it's something to do with the Agariomods evergreen script. When that is enabled, agario-ninja breaks. Try testing it with that.

ghost commented 9 years ago

^ I was going to report the bug that jez9999 mentions here, as it was mentioned in IRC just now.

ghost commented 9 years ago

@DaniGuardiola are you interested in making your modification available to agariomods users? Our code is closed source, so I don't know how that sits with you, but if youre interested in getting involved - even if its just to keep your mod maintained in our extension you will be welcome.

DaniGuardiola commented 9 years ago

I'd like to keep it open source but we can collaborate to make both mods work fine together

DaniGuardiola commented 9 years ago

An example that just came to my head: I can add shortcuts like I do for settings to agariomods stuff like the acid mode (which, by the way, I love)