search

DaniSchenk / moment-feiertage

MomentJS Plugin: Check if a date is a german holiday (Feiertag)
https://www.npmjs.com/package/moment-feiertage
30 stars 11 forks source link

Enable strict-mode #8

Closed nilsmehlhorn closed 5 years ago

nilsmehlhorn commented 5 years ago

Migrates the extension to use JavaScript's strict mode.

Motiviation: Bundlers/compilers may put the script in a strict environment where it may fail due to certain violations. This is for instance the case with the newest Angular 8 compiler due to this update: https://github.com/angular/angular/pull/30122

DaniSchenk commented 5 years ago

Hey @nilsmehlhorn, thx for your contribution. Do you have any idea, why github is complaining about merge conflicts although your PR is already merged (6ea0b7a08c8a5b5d81f836493235ad4c55b7d0e9) successfully?

nilsmehlhorn commented 5 years ago

Thanks for accepting @DaniSchenk! Nope, no clue. Did you merge it via the GitHub web interface? Weird that it doesn't show that the merge happened here.

Would you mind releasing the newest version to npm? :blush:

DaniSchenk commented 5 years ago

@nilsmehlhorn npm version is published. https://www.npmjs.com/package/moment-feiertage

Yes, I used the github web interface, strange 🤔