DanieShannon
commented
6 years ago Hi Karl
Thank you for this very useful feedback. I'm going to implement and keep testing.
I'd like to add that I really enjoyed the course and feel well prepared to continue learning Python in more depth.
Rubric Score
Criteria 1: Valid Python Code
Score Level: 1/4 (Needs Improvement) Comments: Make sure to test all of the functions. When we uncomment the calls to highest_rated_book, most_read_book, and most_positive_reader in the populate.py script, a number of errors are thrown. These errors are described in issues #1, #2, #3, #4, and #5.
Criteria 2: Implementation of Project Requirements
Score Level: 3/4 (Meets Expectations) Comments: All of the functions are implemented, however the highest_rated_book, most_read_book, and most_positive_reader do not return the proper output because the 'count' variables are not updated (see issue #6).
Criteria 3: Software Architecture
Score Level: 4/4 (Exceeds Expectations) Comments: All of your code is grouped into classes and functions appropriately. Well done!
Criteria 4: Uses Python Language Features
Score Level: 4/4 (Exceeds Expectations) Comments: You consistently use Python language features when appropriate. Good job!
Overall Score: 12/16 (Meets Expectations)
Nice work on this overall! My main recommendation for you is to be sure to thoroughly test your code. Make sure to test every function with a variety of different inputs, and try calling your functions in different orders. The more tests that you run, the more likely you are to catch any errors in your code. Again, well done, and good luck as you move forward with your programming!