Daniel-Diaz / matrix

A Haskell native implementation of matrices and their operations.
BSD 3-Clause "New" or "Revised" License
35 stars 31 forks source link

Parametric (rather than overloaded) matrix multiplication? #62

Open kindaro opened 5 years ago

kindaro commented 5 years ago

Sometimes one may wish to use different operations for matrix multiplication than the usual ring operations of the Num instance. For instance, one may find the transitive closure of a relation (represented by a boolean matrix) by iterating matrix multiplication with ^ (Haskell &&) instead of the algebraic boolean addition. Were a Num instance to be defined with the ^ operation, it would not have a well-behaving negate, so defining such an instance is a poor and dangerous solution. But, due to the absence of parametric matrix multiplication, defining such a broken instance is the only way to obtain the transitive closure using matrix multiplication on Bool.

I propose that we add operations multStdBy and so on, that accept two functions as arguments — one to use as addition, another as multiplication. Note that the ^ operation can be defined in terms of the algebraic operations (as x ^ y = x + y + xy) which can be safely represented by a Num instance for a data type with two members, giving a nice and safe solution for my example.

Daniel-Diaz commented 5 years ago

I think you can solve this by using newtype. Say you want to use a certain type T with a different implementation of + and *. Then you create a newtype wrapper for T:

newtype U = U T

And now you define a different Num instance for U. You can easily go back and forth between the two types.

kindaro commented 5 years ago

@Daniel-Diaz That is how I was working around it, but I decided to remove this Num instance because it is dangerous, as I described in the first post above. So now I am projecting to Integer, doing multiplications there and then retracting the projection with fmap (toEnum . signum). Whichever way I go around it, there are drawbacks: