Daniel-Khodabakhsh / datetime-format

Gnome extension which allows users to customise the datetime format on the status bar and date menu.
GNU General Public License v3.0
30 stars 15 forks source link

Error when loading Preferences dialog. #12

Open fishnet37222 opened 5 years ago

fishnet37222 commented 5 years ago

I installed this extension in Ubuntu 18.10 using the Gnome Extensions web-site. When I tried to open the Preferences dialog in Gnome Tweak Tool to customize the format, I got the following error message and stack trace.

TypeError: (new Date(...)).toLocaleFormat is not a function

Stack trace:
  dateTimeFormat@/home/dave/.local/share/gnome-shell/extensions/datetime-format@Daniel-Khodabakhsh.github.com/Utilities.js:15:85
  updatePreview@/home/dave/.local/share/gnome-shell/extensions/datetime-format@Daniel-Khodabakhsh.github.com/FormatTarget.js:49:25
  create@/home/dave/.local/share/gnome-shell/extensions/datetime-format@Daniel-Khodabakhsh.github.com/FormatTarget.js:55:2
  buildPrefsWidget/<@/home/dave/.local/share/gnome-shell/extensions/datetime-format@Daniel-Khodabakhsh.github.com/prefs.js:136:61
  buildPrefsWidget@/home/dave/.local/share/gnome-shell/extensions/datetime-format@Daniel-Khodabakhsh.github.com/prefs.js:136:2
  _selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:83:22
  wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
  _onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:235:17
  wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
  main@resource:///org/gnome/shell/extensionPrefs/main.js:389:5
  @<main>:1:43
christofferholmstedt commented 5 years ago

Same issue as for Fedora see #13, not completely fixed but it is a good start with the changes from @danieljrmay

I just installed Ubuntu 18.10 and got the same error. Clone the changes from https://github.com/danieljrmay/datetime-format and now the settings page works at least.