Daniel12321 / NPCs

MIT License
18 stars 13 forks source link

Skins does not work correctly (2.0.0) #19

Closed crymates closed 7 years ago

crymates commented 7 years ago

If you choose an skin for an NPC it works just for a while. In config it's correct, but after some hours it switchs to default skin :/

crymates commented 7 years ago

Edit: It was an client bug. Dunno if it means an fail by ur plugin. After I reconnected the skins we're fine. Maybe bc of an range if u connect and not all skins are loaded for the client?

crymates commented 7 years ago

It looks like chunk based. If I log in just the skins near to me are loaded correctly. When I move some meters away to other NPC's they are not loaded, just the ones where I logged in :/ So actually u need to reconnect every 10 meters :D

TherealJez commented 7 years ago

Same issue here

crymates commented 7 years ago

Do u use the APi 5 too?

TherealJez commented 7 years ago

No I use 6, so that's probably why they also vanish.

crymates commented 7 years ago

Good to know. I wanted to try out if just the API 5 release bugs. Are messages and delays also not working for u?

TherealJez commented 7 years ago

I didn't try, I removed it since it is probably broken as heck.

crymates commented 7 years ago

Seems like fixed in 2.0.1 - but I read nothing about it in release summary? :D Using API 6 ;)

Daniel12321 commented 7 years ago

Skins are always a little bit buggy, even in vanilla minecraft. I cant get skins to work in offline mode, and skins sometimes dont load correctly. There is not really anything i can do about it at this moment.

Daniel12321 commented 7 years ago

Closing now, as #12 is the same issue.

crymates commented 7 years ago

Its just like the following: U login and u are in chunk 1. NPCs in chunk 1 are loaded, NPCs in chunk 2 are not loaded until u relogin in chunk 2.

Is there no way you could "refresh" or "reload" the NPCs skin every time an player enters their CHUNK? Maybe it fixes it.

crymates commented 7 years ago

And what about offline mode? It's not offline if I am logged in using legal mc? :P Explain what u mean with it pls.

crymates commented 7 years ago

And, furthermore, NPCs runs on my server, which is online too :P