Daniel12321 / NPCs

MIT License
18 stars 13 forks source link

Console error! npc commands wont work #34

Open 3DWafflee opened 7 years ago

3DWafflee commented 7 years ago

Could not pass InteractEntityEvent$Secondary$MainHand$Impl to Plugin{id=npcs, name=NPCs, version=2.0.2-API5, description=A plugin that adds simple custom NPC's to your worlds., url=https://github.com/Daniel12321/NPCs, authors=[Daniel12321], source=/home/AMP/.ampdata/instances/ATM/Minecraft/./mods/plugins/NPCs-2.0.2-API5.jar} Console 09/02/2017 06:41:19 06:41:19java.lang.NoSuchMethodError: me.rojo8399.placeholderapi.PlaceholderService.replacePlaceholders(Lorg/spongepowered/api/entity/living/player/Player;Ljava/lang/String;)Lorg/spongepowered/api/text/Text; at me.mrdaniel.npcs.managers.placeholders.PlaceHolderAPIManager.format(PlaceHolderAPIManager.java:49) ~[PlaceHolderAPIManager.class:?] at me.mrdaniel.npcs.managers.placeholders.PlaceHolderAPIManager.formatCommand(PlaceHolderAPIManager.java:32) ~[PlaceHolderAPIManager.class:?] at me.mrdaniel.npcs.data.npc.actions.ActionPlayerCommand.execute(ActionPlayerCommand.java:32) ~[ActionPlayerCommand.class:?] at me.mrdaniel.npcs.managers.ActionManager.execute(ActionManager.java:71) ~[ActionManager.class:?] at me.mrdaniel.npcs.listeners.WorldListener.lambda$null$7(WorldListener.java:68) ~[WorldListener.class:?] at java.util.Optional.ifPresent(Optional.java:159) ~[?:1.8.0_141] at me.mrdaniel.npcs.listeners.WorldListener.lambda$onClick$8(WorldListener.java:62) ~[WorldListener.class:?] at java.util.Optional.ifPresent(Optional.java:159) ~[?:1.8.0_141] at me.mrdaniel.npcs.listeners.WorldListener.onClick(WorldListener.java:57) ~[WorldListener.class:?] at org.spongepowered.common.event.listener.InteractEntityEventListener_WorldListener_onClick223.handle(Unknown Source) ~[?:?] at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:313) ~[SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:297) ~[SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:338) ~[SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:326) ~[SpongeModEventManager.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:143) ~[SpongeImpl.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.common.event.SpongeCommonEventFactory.callInteractEntityEventSecondary(SpongeCommonEventFactory.java:481) ~[SpongeCommonEventFactory.class:1.10.2-2281-5.2.0-BETA-2597] at net.minecraft.network.NetHandlerPlayServer.func_147340_a(NetHandlerPlayServer.java:2387) ~[me.class:?] at net.minecraft.network.play.client.CPacketUseEntity.func_148833_a(SourceFile:68) ~[iu.class:?] at net.minecraft.network.play.client.CPacketUseEntity.func_148833_a(SourceFile:12) ~[iu.class:?] at org.spongepowered.common.network.PacketUtil.lambda$onProcessPacket$0(PacketUtil.java:157) ~[PacketUtil.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.common.event.tracking.CauseTracker.switchToPhase(CauseTracker.java:163) [CauseTracker.class:1.10.2-2281-5.2.0-BETA-2597] at org.spongepowered.common.network.PacketUtil.onProcessPacket(PacketUtil.java:156) [PacketUtil.class:1.10.2-2281-5.2.0-BETA-2597] at net.minecraft.network.PacketThreadUtil$1.redirect$onProcessPacket$zjj000(SourceFile:539) [fl$1.class:?] at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [fl$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_141] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_141] at net.minecraft.util.Util.func_181617_a(SourceFile:45) [h.class:?] at org.spongepowered.common.SpongeImplHooks.onUtilRunTask(SpongeImplHooks.java:238) [SpongeImplHooks.class:1.10.2-2281-5.2.0-BETA-2597] at net.minecraft.server.MinecraftServer.redirect$onRun$zhp000(MinecraftServer.java:3951) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_141]

DrZoddiak commented 7 years ago

Appears to be directly related to the inclusion PlaceholderAPI. Upon removal of it, it seems to allow the right click event to function properly.

DrZoddiak commented 7 years ago

https://github.com/Daniel12321/NPCs/blob/51830c2ea8931bd39817d394cf2ba98b843818e5/src/main/java/me/mrdaniel/npcs/managers/placeholders/PlaceHolderAPIManager.java#L49

I tracked the issue to be the return statement specifically. It looks like the return should be something along the lines of return this.service.replacePlaceholders(txt,p,p);

Daniel12321 commented 7 years ago

This issue comes from an update in PlaceholderAPI. Ive been slowly working on a huge amount of changes in the plugin, including a fix for this. I dont know when it will be out yet.