Open ziceptor opened 6 years ago
Any errors on startup?
no error
Alright, i managed to reproduce the problem. It only happens on the spongeforge and not spongevanilla. Trying to fix it now.
It appears some stuff has changes recently to where Mixins are no longer possible on spongeforge. I will try to remove all mixin's, however i already know this will severely influence some key aspects of the plugin negatively.
As far as I know. Mixins are working on spongeforge.
Something like that. https://ore.spongepowered.org/ewoutvs_/DoubleJump/discuss
Having the same issue. Would be awesome if you could get a quick fix out. :)
At leisure. At desire. :)
Just wanted to say i too am looking forward to a fix for this :)
@Daniel12321 Any updates on 1.12.2 progress?
Here's an error log from my server: https://hastebin.com/aworimiwop.txt
As a temporary solution @Seathre you can assemble yourself with the fix https://github.com/LXGaming/NPCs
@ziceptor Which branch is supposed to be working?
@ziceptor I was able to make a build using that branch, however it didn't seem to solve the issue I'm having. My server is running Forge build 2586 and SpongeForge 2970.
Heading to bed, will do more troubleshooting later.
Guys, I just wasted a couple of hours trying to create a jar file with the help of the files provided by LXGaming, but it turns out that I am hopeless when it comes to Intelij or any other programming tools. Guess I am just a user and not a creater after all. Could any of you PLEASE share the compiled jar file with us? I have been waiting for a fix to the sponge forge issue for months. :)
@ziceptor Thank you. Just tested, seems to work perfectly.
So.. i'm concerned by the .exe it tries to make me download; since i'm looking for a .jar.......
That being said; could someone post a link to just the jar file? I don't use windows so an .exe is useless to me.
You clicked the wrong link. (exe is an ad/adware/malware) Just click the link above again, you will get the correct site without the adlayer.
But this npc versions seems to break if other plugins use bstats like MCClans. https://pastebin.com/aj1ELgA2
Guess this code part is the culprit: https://github.com/Daniel12321/NPCs/blob/api7/src/main/java/me/mrdaniel/npcs/bstats/MetricsLite.java#L166
@hellbringer616 Here's a bit of a more trustworthy link: https://mega.nz/#!pw8CDBzQ!8JU2Y1QXl9TJK7lNi4d4plhhi-cNvVsKNO_9UhqXs1c
As I said, works for me, although your mileage may vary, as noted by @i9hdkill.
@hellbringer616 Just close. It is offered to download the client to work with the cloud.
Thank you so much, ziceptor! I've just tested it and it works :) I can finally start filling my and my friends' server with NPCs. I didn't expect that many answers so fast, you guys are amazing. Many thanks!
I seem to have other plugins that use bstats as the plugin seems broken; it doesn't throw errors but i can't create any NPC's
@ziceptor With the modified, improved jar, there seems to be an issue I'm running into. Upon server PREINT it relays that there are 2 of the same NPCs plugin present. However, there are not. There is only one present, for sure. Error: https://pastebin.com/eESbcYr6
Any assistance appreciated! And thanks m8~
EDIT: fyi, this results in a full server crash.
@ziceptor Thank you so very much! You're efforts are greatly appreciated, it works!~
@Seathre My url is militant?
@ziceptor lol no, I just re uploaded the file for English speaking people.
Thanks for this working version! Small issue: When rightclicking villager npcs, their trade gui is showing up
@Daniel12321 we are waiting for You ;)
@ziceptor Is your 1.12.2 branch in line with your released jar file? If not, could you push your latest changes?
It seems the plugin is not loading. There are no npc commands after the server starts. The plugin is not in the list /sp plugins
forge-1.12.2-14.23.2.2611-universal.jar spongeforge-1.12.2-2611-7.1.0-BETA-2931.jar NPCs-3.0.0-MC1.12.2.jar