Daniel12321 / NPCs

MIT License
18 stars 13 forks source link

It seems not working 1.12.2 #44

Open ziceptor opened 6 years ago

ziceptor commented 6 years ago

It seems the plugin is not loading. There are no npc commands after the server starts. The plugin is not in the list /sp plugins

forge-1.12.2-14.23.2.2611-universal.jar spongeforge-1.12.2-2611-7.1.0-BETA-2931.jar NPCs-3.0.0-MC1.12.2.jar

Daniel12321 commented 6 years ago

Any errors on startup?

ziceptor commented 6 years ago

no error

Daniel12321 commented 6 years ago

Alright, i managed to reproduce the problem. It only happens on the spongeforge and not spongevanilla. Trying to fix it now.

Daniel12321 commented 6 years ago

It appears some stuff has changes recently to where Mixins are no longer possible on spongeforge. I will try to remove all mixin's, however i already know this will severely influence some key aspects of the plugin negatively.

ziceptor commented 6 years ago

As far as I know. Mixins are working on spongeforge.

ziceptor commented 6 years ago

Something like that. https://ore.spongepowered.org/ewoutvs_/DoubleJump/discuss

PixelmonChampion commented 6 years ago

Having the same issue. Would be awesome if you could get a quick fix out. :)

ziceptor commented 6 years ago

At leisure. At desire. :)

SirFancyBacon commented 6 years ago

Just wanted to say i too am looking forward to a fix for this :)

Seathre commented 6 years ago

@Daniel12321 Any updates on 1.12.2 progress?

Here's an error log from my server: https://hastebin.com/aworimiwop.txt

ziceptor commented 6 years ago

As a temporary solution @Seathre you can assemble yourself with the fix https://github.com/LXGaming/NPCs

Seathre commented 6 years ago

@ziceptor Which branch is supposed to be working?

ziceptor commented 6 years ago

https://github.com/LXGaming/NPCs/tree/1.12

Seathre commented 6 years ago

@ziceptor I was able to make a build using that branch, however it didn't seem to solve the issue I'm having. My server is running Forge build 2586 and SpongeForge 2970.

Heading to bed, will do more troubleshooting later.

baron-v-hinten commented 6 years ago

Guys, I just wasted a couple of hours trying to create a jar file with the help of the files provided by LXGaming, but it turns out that I am hopeless when it comes to Intelij or any other programming tools. Guess I am just a user and not a creater after all. Could any of you PLEASE share the compiled jar file with us? I have been waiting for a fix to the sponge forge issue for months. :)

ziceptor commented 6 years ago

https://cloud.mail.ru/public/DVz5/tqrovDaEF

Seathre commented 6 years ago

@ziceptor Thank you. Just tested, seems to work perfectly.

SirFancyBacon commented 6 years ago

So.. i'm concerned by the .exe it tries to make me download; since i'm looking for a .jar.......

That being said; could someone post a link to just the jar file? I don't use windows so an .exe is useless to me.

johnfriedrich commented 6 years ago

You clicked the wrong link. (exe is an ad/adware/malware) Just click the link above again, you will get the correct site without the adlayer.

But this npc versions seems to break if other plugins use bstats like MCClans. https://pastebin.com/aj1ELgA2

Guess this code part is the culprit: https://github.com/Daniel12321/NPCs/blob/api7/src/main/java/me/mrdaniel/npcs/bstats/MetricsLite.java#L166

Seathre commented 6 years ago

@hellbringer616 Here's a bit of a more trustworthy link: https://mega.nz/#!pw8CDBzQ!8JU2Y1QXl9TJK7lNi4d4plhhi-cNvVsKNO_9UhqXs1c

As I said, works for me, although your mileage may vary, as noted by @i9hdkill.

ziceptor commented 6 years ago

@hellbringer616 Just close. It is offered to download the client to work with the cloud.

baron-v-hinten commented 6 years ago

Thank you so much, ziceptor! I've just tested it and it works :) I can finally start filling my and my friends' server with NPCs. I didn't expect that many answers so fast, you guys are amazing. Many thanks!

SirFancyBacon commented 6 years ago

I seem to have other plugins that use bstats as the plugin seems broken; it doesn't throw errors but i can't create any NPC's

PrimalMew commented 6 years ago

@ziceptor With the modified, improved jar, there seems to be an issue I'm running into. Upon server PREINT it relays that there are 2 of the same NPCs plugin present. However, there are not. There is only one present, for sure. Error: https://pastebin.com/eESbcYr6

Any assistance appreciated! And thanks m8~ screenshot_2

EDIT: fyi, this results in a full server crash.

ziceptor commented 6 years ago

fix jar https://cloud.mail.ru/public/5UJU/wpqsugfMp

PrimalMew commented 6 years ago

@ziceptor Thank you so very much! You're efforts are greatly appreciated, it works!~

Seathre commented 6 years ago

Friendlier links: https://drive.google.com/open?id=1mCfYZTfI8eLrrpTUXit_DY6H4iQ1tBHm https://mega.nz/#!x0MBWCQL!k-igwRwPikFSG1xCJxSixxQ2d2Y6jlV3xo9ri7-RpOg

ziceptor commented 6 years ago

@Seathre My url is militant?

Seathre commented 6 years ago

@ziceptor lol no, I just re uploaded the file for English speaking people.

johnfriedrich commented 6 years ago

Thanks for this working version! Small issue: When rightclicking villager npcs, their trade gui is showing up

ziceptor commented 6 years ago

@Daniel12321 we are waiting for You ;)

johnfriedrich commented 6 years ago

@ziceptor Is your 1.12.2 branch in line with your released jar file? If not, could you push your latest changes?