Add missing configuration property + other stuff for the `LowerCaseUrls` option

Daniel15 / RouteJs

JavaScript URL routing for ASP.NET MVC and WebForms

84 stars 19 forks source link

Add missing configuration property + other stuff for the `LowerCaseUrls` option #46

Closed mrahhal closed 8 years ago

mrahhal commented 8 years ago

[x] Fix lowerCaseUrls unrecognized in web.config
[x] Add support for AspNet 5
[x] Reuse things as much as possible
[x] Fix: "Articles/{key}/Edit" is being converted to "articles/{key}/Edit"
[x] Add tests to cover these cases
[x] Make the lowercase option reachable from javascript, so that we can generate lowercase urls for default routes (a default route is still generated as normal)
[x] Convert all the things from js

Fixes #45

mrahhal commented 8 years ago

Hey @Daniel15 I'm actually failing to build RouteJs locally (except for RouteJs.AspNet), there is a SharedAssemblyVersionInfo.cs included in all of the projects excluding RouteJs.AspNet. But this is nowhere to be found and it's resulting in a build error, what's going on?

According to the projects, it should be in src right next to SharedAssemblyInfo.cs.

mrahhal commented 8 years ago

One thing I noticed, it might have been better to just keep everything in the javascript side (convert as necessary when building the routes in js). I didn't know we'll need to do something in js when I started writing LowerCaseRouteProcessor. But is it really worth it now that we have everything working? I don't mind rewriting the pieces (it will actually be easier) in js if you think that's better than having a new interface (IRouteProcessor) to manage.

mrahhal commented 8 years ago

So this was really awkward, turns out we could do everything so much easier in javascript. Also, we don't care for case inside param values (I didn't know that). So the result is that we can do everything from js and in so much less code (no need for IRouteProcessor or pretty much everything else on the server anymore).

I'm happy with what we have here, so unless you have something to change I think this is done. I tested using the dev package.

Daniel15 commented 8 years ago

there is a SharedAssemblyVersionInfo.cs included in all of the projects excluding RouteJs.AspNet. But this is nowhere to be found and it's resulting in a build error, what's going on?

Running build-dev.bat will create that file.

Daniel15 commented 8 years ago

Thanks! This looks pretty good. Just a few small comments (inline). Doing the lowercasing in JS does look a lot simpler :)

mrahhal commented 8 years ago

Right, doing those now.

Daniel15 commented 8 years ago

This looks good to me, thanks! Is this ready to merge? If so, can you please squash your commits?

mrahhal commented 8 years ago

Yes this is squashed and ready. Didn't have the time to test this with AspNet 5 though.