Escape IconUrl value before we output it.

Daniel15 / simple-nuget-server

A very simple PHP NuGet server

MIT License

116 stars 43 forks source link

Escape IconUrl value before we output it. #6

Closed miyu closed 9 years ago

miyu commented 9 years ago

Simple-nuget-server threw an unterminated entity reference error when I pushed xunit 1.9.2 to our NuGet repository. The xunit package has IconUrl "http://download.codeplex.com/Download?ProjectName=xunit&DownloadId=365445", which needs to be escaped to "http://download.codeplex.com/Download?ProjectName=xunit&DownloadId=365445".

Moving the string escape to the $entry->addChild invocation at addMeta probably makes more sense, though I haven't tested that.

miyu commented 9 years ago

Same issue happens with ImpromptuInterface 6.2.2 - Added an escape for description. Once again, probably makes more sense to move escape to entry->addChild call.

Daniel15 commented 9 years ago

Seems fine to me. Thanks!