search

DanielAndreasen / SWEETer-Cat

Make SWEET-Cat sweet again
http://sweetercat.herokuapp.com/
MIT License
12 stars 1 forks source link

Update the CSS. Bootstrap4? #132

Closed DanielAndreasen closed 3 years ago

DanielAndreasen commented 6 years ago

Some of the boxes for input (for plots) looks bad. We probably need to switch to bootstrap 4.

image

jason-neal commented 6 years ago

How easy is that? Is it as simple as changing something like bootstrap=3.xx to bootstrap=4.0 without changing much else?

DanielAndreasen commented 6 years ago

I'm not sure. It was getting late when I saw this. It could be more thant that. Here it also seems like it is only the dropdowns that are a problem.

jason-neal commented 6 years ago

From https://getbootstrap.com/docs/4.1/getting-started/introduction/ The new link should be <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css" integrity="sha384-MCw98/SFnGE8fJT3GXwEOngsV7Zt27NXFoaoApmYm81iuXoPkFOJwJ8ERdknLPMO" crossorigin="anonymous">

to replace line 11 from sweetercat/templates/template.html

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootswatch/3.3.7/united/bootstrap.min.css">

I have not had a chance to test this yet but there should not be any breaking changes.'

I am not sure if there is a difference between maxcdn and stackpath. Update: maxcdn has moved to/into stackpath

Also not sure if the other links need to be updated also. datatables and scroller

DanielAndreasen commented 5 years ago

Note that the one already there is from bootswatch with the theme included. We should probably go there to find the proper new link.

jason-neal commented 5 years ago

Ahh thanks, That would be <link href="https://stackpath.bootstrapcdn.com/bootswatch/4.1.3/united/bootstrap.min.css" rel="stylesheet" integrity="sha384-+d4wMJSxEP3vzs2qZBElQRTZMXwgWH15Nyn2K/9XjKiHmh3sBuk1Un/IbcdMcYC4" crossorigin="anonymous">