search

DanielArnould / react-pdf-highlighter-extended

📄 Set of modern React components for PDF highlighting
https://danielarnould.github.io/react-pdf-highlighter-extended/example-app/
MIT License
43 stars 16 forks source link

Merge with original repo #17

Open agentcooper opened 1 month ago

agentcooper commented 1 month ago

Hey @DanielArnould, would you be interested in collaborating on merging some of your changes to the original repo? I recently pushed an upgrade to PDF.js 4.

DanielArnould commented 1 month ago

Sure, I'm happy to help where I can. What changes were you thinking of? Most of my changes were structural though and would be breaking changes if brought over to the original repo.

agentcooper commented 1 month ago

I guess the first step would be upgrading internal implementation to function components and hooks. Would it be alright if I'll use some of your code for this?

Then we can sync about the public facing API and see what can be merged.

DanielArnould commented 1 month ago

Yep, sounds good 👍 .