search

DanielBok / nlopt-python

A project to package the NLOpt library to wheels
Other
29 stars 14 forks source link

Please add release on PyPI for python 3.11 #19

Closed AntoineD closed 1 year ago

AntoineD commented 1 year ago

@DanielBok @HDembinski Would it be possible for you to build the package for python 3.11?

AntoineD commented 1 year ago

@HDembinski @DanielBok Please let me know if you intend to build a python 3.11 package.

HDembinski commented 1 year ago

Hi, I haven't been very active since I joined, but I can give it a try if Daniel is busy.

AntoineD commented 1 year ago

That would be awesome! Thanks.

HDembinski commented 1 year ago

@AntoineD Looks like Daniel has already started working on supporting 3.11, see https://github.com/DanielBok/nlopt-python/tree/develop/3.11

DanielBok commented 1 year ago

@HDembinski couldn't figure out why the cmake wouldn't build in the github actions. If you have some time, could you take a look at it? (I'm not proficient with cmake)

HDembinski commented 1 year ago

I had a look at the CI logs, but I do not see why it is failing. It is funny that Windows 3.11 succeeds, while every other platform fails.

I can try to build the wheel locally to better understand the issue, but I don't have quick fix at hand.

AntoineD commented 1 year ago

In the short term and in order to be able to use the package for python 3.11, how about just building for python 3.11 and push the packages to PyPI?

HDembinski commented 1 year ago

@AntoineD I also thought that it is that simple, but apparently not. nlopt-python is not released very often and it seems that in the meantime some GitHub update broke our builds. At least that's how I understand the situation from looking at the logs, but @DanielBok should know better.

AntoineD commented 1 year ago

From the git history it looks like you @DanielBok is trying to build an updated version of nlopt. Would it be possible to build the already last released version of nlopt-python just for python 3.11? That seems possible by disabling the build for all other python versions of the github actions.

AntoineD commented 1 year ago

Hello, how about the suggestion in my previous post?

FrancoisGallard commented 1 year ago

Hello, Having nlopt work with python 3.11 would be really great since it provides a huge performance boost. Is there anything we can do to help?

Thanks François

LukeLabrie commented 1 year ago

Would also be interested in having a python3.11-compatibile version

peterdsharpe commented 1 year ago

Hi all,

Seconding (or, fifth-ing?) that this nlopt-on-3.11 issue is causing a block for us as well in building downstream packages:

https://github.com/CadQuery/cadquery/issues/1248

With Python 3.11 becoming increasingly common in the wild these days, I suspect that this will begin to affect a ever-growing fraction of nlopt-python's user base.

@DanielBok @HDembinski , any word on when a 3.11 build on PyPI will be available?

mojca commented 1 year ago

Is NumPy optional?

Could NOT find NumPy (missing: NUMPY_INCLUDE_DIRS)

And the second weird thing. There seems to be some mixup between Python 3.11 and 3.8. The same build job finds both, and when I install the package on Windows with Python 3.11, it just installs the one with 3.8 in the name.

DanielBok commented 1 year ago

Hi all, added 3.11.

Thank you @khwilson who helped with the mac build.

khwilson commented 1 year ago

Glad to help! Congrats on the release and thanks again for all the work!

FrancoisGallard commented 1 year ago

Great, thank you very much !

lazyzyf commented 7 months ago

can you please add python 12 support as well?