search

DanielBorgesOliveira / onedrive_tray

OneDrive system tray program
GNU General Public License v3.0
113 stars 21 forks source link

New version (2.0) #23

Closed bforest76 closed 2 years ago

bforest76 commented 2 years ago

menu_fr menu_en about_en more colors

jugendhacker commented 2 years ago

"New version" is actually a pretty bad commit message, especially if you use it for five different commits. A good commit message should describe what the commit actually does.

bforest76 commented 2 years ago

"New version" is actually a pretty bad commit message, especially if you use it for five different commits. A good commit message should describe what the commit actually does.

Sorry about that. I'm a very early user of github (it's my first upload) and don't kown exactly how to manage it fine.

jotkah commented 2 years ago

So this version will never be commited because of those "unlucky" commit messages?

jugendhacker commented 2 years ago

@jotkah I don't know, I'm not the maintainer, but good commit messages are always useful if you use git and they could in theory easily be changed via rebasing.

jugendhacker commented 2 years ago

@bforest76 please take a look on https://github.com/pedrolcl/qt-i18n how to to the translations correctly with qmake, so we would not need to but compiled binaries into git and avoid things like loading translations from the binary dir.

bforest76 commented 2 years ago

@bforest76 please take a look on https://github.com/pedrolcl/qt-i18n how to to the translations correctly with qmake, so we would not need to but compiled binaries into git and avoid things like loading translations from the binary dir.

@jugendhacker Thanks a lot for the advice. I will try to do this way.