DanielG / ghc-syb

Scrap Your Boilerplate instances for GHC's data types
8 stars 10 forks source link

Compatibility for NameSet.nameSetToList -> NameSet.nametSetElems #10

Closed markus1189 closed 9 years ago

markus1189 commented 9 years ago

As per [1] nameSetToList is called nameSetElems. For backwards compatibility I simply added a check for the ghc version and if >= 7.10 define nameSetToList = nameSetElems. This relates to e1c8e15 but if I am correct that change would break compatibility.

[1] http://git.haskell.org/ghc.git/commit/7460dafae3709218af651cb8bc47b5f03d4c25c7

Best, Markus

nominolo commented 9 years ago

Thanks, but I fixed it in a slightly different way. See https://github.com/nominolo/ghc-syb/commit/8ca7d3f5a6a2ac29d164872bf0f412832c64b1c9