search

DanielG / ghc-syb

Scrap Your Boilerplate instances for GHC's data types
8 stars 10 forks source link

Fix incorrect CPP conditionals for GHC 8.0 #21

Closed DanielG closed 7 years ago

DanielG commented 7 years ago

This issue is impacting ghc-mod users and blocking the ghc-mod-5.9 release, please consider merging and releasing it soon: https://github.com/DanielG/ghc-mod/issues/908

nominolo commented 7 years ago

Thanks. Merged and released as 0.2.3.3.

BTW, @DanielG would you (or someone else from the ghc-mod team) be interested in taking over maintainership of ghc-syb? It's basically just ghc-syb-utils and I noticed that the test suite actually fails for GHC 8.0+. I haven't used this in several years, and since ghc-mod seems to still be using it, it would probably be much better off in your hands.

DanielG commented 7 years ago

Sure thing. Just add me to the maintainers group on Hackage, my username there is also DanielG, and transfer the repo to me and I'll take over.

nominolo commented 7 years ago

Thanks. I added you to the maintainers on Hackage. In order for transfer to work, you need to remove (or rename) your fork of ghc-syb.

DanielG commented 7 years ago

Done.

DanielG commented 6 years ago

poke

nominolo commented 6 years ago

It says it's in progress...

screen shot 2017-11-15 at 01 03 47

You didn't get a notification?

DanielG commented 6 years ago

Ah I did but it was so long ago it landed in my email archive. It says the transfer has expired tough, so can you just abort it and retry?

nominolo commented 6 years ago

OK, I re-did it. You probably have 24 hours to accept.

DanielG commented 6 years ago

Seems to have worked this time :)

QuLogic commented 6 years ago

If this fixed 8.0 support, then I suppose the README should maybe be updated?

DanielG commented 6 years ago

Honestly until I get around to setting up a CI system I'm not confident enough in any of the version bounds to boast about them ;)