DanielGavin / ols

Language server for Odin
MIT License
417 stars 62 forks source link

Remove writing semantic nodes for untyped and basic value symbols #263

Closed thetarnav closed 10 months ago

thetarnav commented 10 months ago

The result semantic token types were often incorrect for constants and literals like nil, true and false. Syntax grammars have better results here, but were being overridden by the semantic tokens.

I'm not yet familiar enough with the codebase to fix this properly, instead of just removing it.

DanielGavin commented 10 months ago

Think that's fine. I was planning on removing most of the semantic for things that really could be done with syntax grammar.