DanielGavin / ols

Language server for Odin
MIT License
440 stars 68 forks source link

Add "name": "base", "path":"C:\\odin\\base" to auto-generated ols.json to empower completions for base lib packages in ols #312

Closed ghost closed 7 months ago

ghost commented 7 months ago

PLEASE DISREGARD, I WAS WRONG BELOW, GOT HELP FROM ODIN DISCORD.

Daniel, I love the Odin ols extension for VS Code!! Thank you for creating and maintaining this extension it is just so great to use and helps me as someone new to Odin!

Please consider to add base to the ols.json file that is automatically added to new Odin project folders when using ols.

When I updated the default ols.json it works.

laytan and karl thought that: maybe the autofinding code in ols for base doesn't exist yet? and that even without the collections field in the .json that ols should find the base and core folders since "they are next to the compiler"

{
    "$schema": "https://raw.githubusercontent.com/DanielGavin/ols/master/misc/ols.schema.json",
    "collections": [
        {
            "name": "core",
            "path": "C:\\odin\\core"
        },
        {
            "name": "base",
            "path": "C:\\odin\\base"
        }
    ],
    "enable_document_symbols": true,
    "enable_semantic_tokens": false,
    "enable_hover": true,
    "enable_snippets": true
}
ghost commented 7 months ago

I believe I was wrong above. When I followed some advice from the Discord server and deleted the ols.json, everything is working. Sorry for the false alarm.