DanielGavin / ols

Language server for Odin
MIT License
382 stars 58 forks source link

After the new update I get a new error #320

Closed xzores closed 3 months ago

xzores commented 4 months ago

After the new update I get a new error:

[Error - 8:58:28 AM] Failed to read/find c:\Users\jakob\AppData\Roaming\Code\User\globalStorage\danielgavin.ols\147110303/ols.json
D:/a/ols/ols/src/common/fuzzy.odin(193:2) runtime assertion
[Info  - 8:58:28 AM] Connection to server got closed. Server will restart.
true
Hyrtwol commented 4 months ago

I had same error the other day, fixed it for now by creating an empty ols.json file at the location. ols must have trouble detecting if the file exists.

Hyrtwol commented 4 months ago

Oh and ofc it's now missing again after an update, not ideal :p

DanielGavin commented 4 months ago

@Hyrtwol Whether the global file exists or not, should not have any affect on anything, except that it won't use it then. I could stop writing out the error, but it's better to show where it tried to look.

Are you saying something doesn't work if the global file doesn't exist? I would expect more people to have complained about it. Must people don't even know about the global config.

DanielGavin commented 4 months ago

This is related to https://github.com/DanielGavin/ols/issues/316

DanielGavin commented 3 months ago

Fixed in #316

Hyrtwol commented 3 months ago

sry for the late reply, the missing global ols.json don't cause any issues. maybe nice if it could be a warning instead

DanielGavin commented 3 months ago

@Hyrtwol Yeah most likely should be. Technically all of the ols.json missing are technically not errors.