search

DanielGavin / ols

Language server for Odin
MIT License
439 stars 67 forks source link

removed duplicate condition #333

Closed IsaiahPaget closed 6 months ago

IsaiahPaget commented 6 months ago

Hey there Daniel, I am F9pop from the Discord server. I found this duplicate condition, I removed it and all the tests still passed. Let me know what you think, cheers!

DanielGavin commented 6 months ago 
if strings.compare(header_name, "Content-Length") == 0 {

} else if strings.compare(header_name, "Content-Type") == 0 {

}

One is length and the other is type. Doesn't seem like a duplicate to me.

Also the tests do not test the actual request messages. Only the completion, hover, gotos, etc.

You will have to test that manually through your editor.

IsaiahPaget commented 6 months ago

Whoops, I jumped the gun sorry about that.

DanielGavin commented 6 months ago

No worries. Happens.