DanielHabenicht / ngx-vcard

MIT License
13 stars 14 forks source link

Angular 12 Support #540

Closed bkr32 closed 2 years ago

bkr32 commented 2 years ago

The current version of ngx-vcard supports Angular 11, please bring it up to support Angular 12

maxbauer commented 2 years ago

For me it works with Angular12 as well

bkr32 commented 2 years ago

@maxbauer did you happened to do --force or --legacy-deps while installing?

maxbauer commented 2 years ago

Hmm, I do not remember that. I think I just installed it with npm i ngx-vcard

DanielHabenicht commented 2 years ago

Is it working with angular 12? Then I will just increase the package version for now and update the framework later

bkr32 commented 2 years ago

@DanielHabenicht the error given when attempting to install with angular 12 is

npm ERR!   @angular/common@"^12.1.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@">=5.x <11.0.0" from ngx-vcard@3.0.22
DanielHabenicht commented 2 years ago

I know, but if you force it and use it then is it working?

bkr32 commented 2 years ago

@DanielHabenicht yes it seems to work fine using --force this was tested using the directive and not the formatter however

DanielHabenicht commented 2 years ago

:tada: This issue has been resolved in version 3.0.23 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

bkr32 commented 2 years ago

@DanielHabenicht not to be a bother but the error still occurs on sub-versions greater than 12.0.0

npm i ngx-vcard@latest

npm ERR! Found: @angular/common@12.2.2
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^12.1.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@">=5.x <12.0.0" from ngx-vcard@3.0.23
npm ERR! node_modules/ngx-vcard
npm ERR!   ngx-vcard@"3.0.23" from the root project

of course no real issue in terms of installing and using with --force

DanielHabenicht commented 2 years ago

Yep didn't thought that there are already 2 new versions 😅 I will fix it soon

DanielHabenicht commented 2 years ago

:tada: This issue has been resolved in version 3.0.24 :tada:

The release is available on:

Your semantic-release bot :package::rocket: