DanielHaitink / YNABGoingDutch

A converter between the CSV format of Dutch banks and the YNAB format. Or sync your bank statement directly with YNAB!
http://ynab.danielhaitink.nl/
MIT License
46 stars 15 forks source link

Make core available as standalone consumable modules #42

Closed alloy closed 3 years ago

alloy commented 3 years ago

Opening this early and unpolished to illustrate what it could look like and to discuss requirements. I tried to stay as close as possible to your original intent/style, but can totally understand if this is too much of a change for you. (I can always just use this forked code myself, as I don’t imagine there will be much changes in the future.)

Changes:

Considerations:

Closes #41

DanielHaitink commented 3 years ago

Hi, Sorry for the late reply. Have been a bit busy.

Although I am very glad you put so much effort into this, I think these changes are too big for me personally. Especially since we are talking about a small feature. If I were to create an electron build of the system, I think I would be okay with this. However I believe the system is easier and just as safe to use in the browser browser.

You are of course free to fork this project and change all the code as needed.

The only changes that I can foresee (except bugfixes and added support for banks which are easily integrated into your fork) are a merge with the ABN AMRO version of YNABGoingDutch #25 and an integration into the YNAB api #26 . However these features are not guaranteed to be implemented ever.

I can always link to your repo in the readme.md if you'd like. Thanks again for the effort you put into this!

alloy commented 3 years ago

Makes total sense and no worries, I need this so there’s nothing lost here.

The only changes that I can foresee (except bugfixes and added support for banks which are easily integrated into your fork) are a merge with the ABN AMRO version of YNABGoingDutch #25 and an integration into the YNAB api #26 . However these features are not guaranteed to be implemented ever.

I’m tracking the API one, but also don’t foresee it being a real problem to merge back in if it ever gets done.

I can always link to your repo in the readme.md if you'd like.

Yeah that would be nice, I’m sure there will be some other dev at some point that wants this 👍

Thanks again for the effort you put into this!

Thank you for the original work!