search

DanielHindi / aws-s3-zipper

takes an amazon s3 bucket folder and zips it for streaming or serializes to a file
119 stars 74 forks source link

type: feat #22

Open lipeRomani opened 6 years ago

lipeRomani commented 6 years ago

Added new parameter "useCredentials" on constructor to choce if want use key/secret or credentials file on loca folder. Issue #21

Added new parameter "folderPath" on zipToS3File to choce if want bucket folder structure inside zip file or only files. Issue #20

Resolves: #21, #20

DanielHindi commented 6 years ago

Thanks for helping fix these issues. Should probably bump up the package version, right? If you're interested I'm looking for someone to help manage this module. Let me know

lipeRomani commented 6 years ago

Hi @DanielHindi, thanks for the invite, but i don't have much time to invest in that now. Can I help with some pull requests sometimes, but I will not assume this compromise like a collaborator.

And yes, this code will need a version to release, but will not lose the compatibility of the older version, because the two added parameter is optional.

DanielHindi commented 6 years ago

Hey lipeRomani, I've been going through older pull requests and there was one that added the following for credentials https://github.com/DanielHindi/aws-s3-zipper/blob/master/index.js#L10 this I believe deels with #21 Thoughts?

jmcollin78 commented 6 years ago

Hi there, is there any update on this feature ? I'm interested in both update: useCredentials and folderPath

mubarakbello commented 3 years ago

This hasn't been merged since 2018???