Switch to fs.unlinkSync to fix node 10 err

DanielHindi / aws-s3-zipper

takes an amazon s3 bucket folder and zips it for streaming or serializes to a file

119 stars 74 forks source link

Closed tmjoen closed 5 years ago

tmjoen commented 6 years ago

fs.unlink fails without the callback param in node 10 it seems. Switching to fs.unlinkSync fixes the problem for me.

TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
    at makeCallback (fs.js:135:11)
    at Object.unlink (fs.js:903:14)

DanielHindi commented 6 years ago

Good catch! I'll review. Thanks

SeanoNET commented 5 years ago

Hi, do you have an ETA on this fix being released?

DanielHindi commented 5 years ago

Thanks @tmjoen for the fix. @SeanoNET you should be good to go