search

DanielHindi / aws-s3-zipper

takes an amazon s3 bucket folder and zips it for streaming or serializes to a file
119 stars 74 forks source link

temporal zip file is created in /tmp for zipToS3File #8

Closed nuxero closed 4 years ago

nuxero commented 7 years ago

By doing this the library can be used on a Lambda function. Taken from this post: https://medium.com/@sebastindelafuente/using-aws-s3-zipper-in-lambda-aa20728f382a#.jk3vljm68

DanielHindi commented 7 years ago

Hello, I haven't had a chance to to test this yet. However, just looking at the code. It would seem that it will fail if the folder 'tmp' wasn't already created manually , right?

nuxero commented 7 years ago

I believe /tmp is a standard folder used by the operating system, this is true on Mac and Linux. It would fail on windows though. Perhaps a special function for being used on AWS Lambda may do the trick. The thing is that /tmp is the only writable directory on a lambda function.

DanielHindi commented 7 years ago

Maybe making it a property/parameter to be passed in would be a better option. Thoughts?

nuxero commented 7 years ago

yes, I think it would be great

DanielHindi commented 7 years ago

Please make the changes and I'll happily merge your pull request. Thank you for the contribution

Lumnut commented 6 years ago

I have also needed to make this modification, wont bother with pull request as I can see it has already been done, are these changes going through?

bradleyfowler123 commented 5 years ago

Changes made, see PR #34