search

DanielJAlexander / ardupirates

Automatically exported from code.google.com/p/ardupirates
0 stars 0 forks source link

Suggest single point for user-configurable variables #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Since setting up the code can be very confusing to newbies and pro's alike, I 
suggest we move all user-configurable settings towards the ArduUser.h. 
I don't think the main .pde should be the place where users should edit 
settings that are unique to their multirotor, location or person.

Moving all these settings towards ArduUser.h also prevents the situation where 
new code is released and several files have to be manually merged because of 
new code and user-specific changes are conflicting.

In such manner, it's also easier to just try or test several code release 
sequentially without having to edit multiple files each time. 
Improves usability and maintainability.

Original issue reported on code.google.com by kidogof...@gmail.com on 21 Jan 2011 at 7:20

GoogleCodeExporter commented 9 years ago

Original comment by kidogof...@gmail.com on 21 Jan 2011 at 7:21

GoogleCodeExporter commented 9 years ago 
If it's not a big deal, we should separate the config.file from the main code. 
That would also make it easier for the Online Configurator. And much easier for 
noobs! ;)

Original comment by kinderkram@gmail.com on 21 Jan 2011 at 9:40

GoogleCodeExporter commented 9 years ago 
Agreed, good point !

Original comment by kidogof...@gmail.com on 21 Jan 2011 at 9:41

GoogleCodeExporter commented 9 years ago 
Absolutly agreed, I'm waiting on Hein's reply, as I have made a list of all 
defines that should be in the online config, and could be placed in the 
arduser.h or other single .h

Dani

Original comment by Gdani.s...@gmail.com on 21 Jan 2011 at 9:56

GoogleCodeExporter commented 9 years ago 
Hein,
Would you allow me to take your latest (r255) and move all user settings into 
ArduUser.h ? 
Should we give the file a more obvious name like for instance config.h ?

Original comment by kidogof...@gmail.com on 22 Jan 2011 at 12:27

GoogleCodeExporter commented 9 years ago 
I just committed these proposed changes in r256, but I accidentally did so in 
Hein's branch. I'm so sorry, Hein, please forgive me - it won't happen again !
Can someone tell me how I can get the files I have here locally into my own 
branch (Kim) without f*ck!ng up someone else's work ?

Thanks !

Original comment by kidogof...@gmail.com on 22 Jan 2011 at 11:12

GoogleCodeExporter commented 9 years ago 
Could you guys please take a look at r256 and comment ? Thanks !

Original comment by kidogof...@gmail.com on 23 Jan 2011 at 3:52

GoogleCodeExporter commented 9 years ago 
Hi Kidogofoto,

I moved your changes to your folder "Kim".  Please update the ArduPiratesNG 
under the Trunk directly.  This will be the version that all of the developers 
combine their work.  Thanx for changes.  Please update it under trunk....

Greetings,
Hein

Original comment by lohnieh@gmail.com on 23 Jan 2011 at 6:24

GoogleCodeExporter commented 9 years ago 
I have tested your config file. Everything works. There are a few changes 
though that I can make on the descriptions that are not clear for you.
If you are OK with them, I think it is time to upload to the trunk. It will 
make life muche easier for everybody. Also we should arrange to get it in the 
global configurator as Kinderkram suggested. I think it is very much complete 
at the moment.
Emile

Original comment by emile.ca...@gmail.com on 23 Jan 2011 at 11:35

GoogleCodeExporter commented 9 years ago 
Go ahead Emile, and thanks for your help ! ;)

Original comment by kidogof...@gmail.com on 24 Jan 2011 at 7:13

GoogleCodeExporter commented 9 years ago 
It is now in the trunk; I suggest we test and then close this issue.

Original comment by kidogof...@gmail.com on 24 Jan 2011 at 10:03

GoogleCodeExporter commented 9 years ago 
Seems to go well. I'm closing this one.

Original comment by kidogof...@gmail.com on 26 Jan 2011 at 8:58