Closed PaulKlauser closed 2 years ago
I found this to make contributing to this repo easier 😃 Let me know if there's an unintended side-effect to this that I'm not considering.
Hey @PaulKlauser, thanks for your contribution. Unfortunately this won't work since the api included library won't be included when building the konfetti-xml or konfetti-compose. Still have to work on a solution for that
Closing, since this won't actually work when publishing the library's aar
@DanielMartinus it actually looks like maven-publish will generate the POM to point at the published dependency, even if the gradle file is pointed at the local project dependency. I can see this behavior by running ./gradlew konfetti:xml:generatePomFileForReleasePublication
and looking at the output POM file.
Looks like the issue is just that the artifactId is named core
instead of konfetti-core
, which is what the core module is being published to so it ends up not matching.
The solution would be to set the project name explicitly to konfetti-core
which can be done by changing the directory name, or adding a line to the settings.gradle
, which I'll add to this PR in a second
See #295 with a setup that works using the local core library and where publishing used the remote core dependency
This allows the sample apps to be used to test changes to the libraries without needing to publish