search

DanielMartinus / Konfetti

Celebrate more with this lightweight confetti particle system 🎊
ISC License
3.13k stars 299 forks source link

Merge library modules #294

Closed DanielMartinus closed 2 years ago

DanielMartinus commented 2 years ago

Merges the modules into a single library module. Having multiple modules as a library is not very optimal when publishing an aar. When building the aar transitive modules are not packaged into the final aar. To solve that I published the core module as a separate library and let the xml and compose libraries include it. However, for contributors this could be a bit confusing and when publishing a new version the core library always has to be published first.

To simplify the library setup the modules are now merged into one. This might also mean that I'll go back using: nl.dionsegijn.konfetti instead of: nl.dionsegijn.konfetti-xml and nl.dionsegijn.konfetti-compose

A reason for changing the package name is that I noticed it also lead to some confusion with some library users that accidentally picked the wrong name. I might publish another version at konfetti-xml and konfetti-compose with deprecation warnings to tell people migrating to the new library name.

This fixes #290

DanielMartinus commented 2 years ago

Closing this branch since I'm working as we speak on another solution. I've indeed ran into the same thought as stated here (cc @PaulKlauser). I've also ran into some other issues with the way the project is currently setup. I like the split between View based and Compose and would like to keep this separated.