Closed DanielMartinus closed 2 years ago
@DanielMartinus I'm curious if you saw my comment here: https://github.com/DanielMartinus/Konfetti/pull/290#issuecomment-1040869971
The solution you have in this PR gets the job done, but it is adding complexity for something the maven-publish plugin is built to handle
This PR does two things:
konfetti-xml
andkonfetti-compose
the core module is pulled from the remote Maven repository. This way the pom refers to a remote copy ofkonfetti-core
so that it works as a transitive dependency.This is a follow-up on https://github.com/DanielMartinus/Konfetti/pull/290.
When building a release the core module needs to be pulled from the remote maven repository so that it can be included in the pom file. Other option was using
fat aar
to include core's files. Though what I read is that maintaining fat aar can be lots of work. One downside of this solution is that core always needs to be published first before publishingkonfetti-xml
andkonfetti-compose
.