DanielMartinus / Konfetti

Celebrate more with this lightweight confetti particle system 🎊
ISC License
3.19k stars 301 forks source link

Setup core transitive dependency #295

Closed DanielMartinus closed 2 years ago

DanielMartinus commented 2 years ago

This PR does two things:

This is a follow-up on https://github.com/DanielMartinus/Konfetti/pull/290.

When building a release the core module needs to be pulled from the remote maven repository so that it can be included in the pom file. Other option was using fat aar to include core's files. Though what I read is that maintaining fat aar can be lots of work. One downside of this solution is that core always needs to be published first before publishing konfetti-xml and konfetti-compose.

PaulKlauser commented 2 years ago

@DanielMartinus I'm curious if you saw my comment here: https://github.com/DanielMartinus/Konfetti/pull/290#issuecomment-1040869971

The solution you have in this PR gets the job done, but it is adding complexity for something the maven-publish plugin is built to handle