search

DanielMartinus / Konfetti

Celebrate more with this lightweight confetti particle system 🎊
ISC License
3.13k stars 299 forks source link

fix: drawable shape fade in compose #301

Closed dostalleos closed 1 year ago

dostalleos commented 1 year ago

Fixed DrawableShape fade-out animation in the Compose ConfettiView. Currently, it doesn't work as expected. It juts flickers somehow.

DanielMartinus commented 1 year ago

Hi @dostalleos, thanks for opening a Pull Request. Could you please elaborate a little more on why you're fixing this alpha? Running some tests I don't see any issues with the Alpha.

dostalleos commented 1 year ago

@DanielMartinus Unfortunately, I do not remember exactly. I think that the particles were flickering before being invisible. It was happening only when using DrawableShape.

DanielMartinus commented 1 year ago

Thanks @dostalleos. Do you remember on what device/os type this happened?

dostalleos commented 1 year ago

@DanielMartinus Unfortunately not. But I think it was happening on all the devices we tested.

DanielMartinus commented 1 year ago

When validating this fix https://github.com/DanielMartinus/Konfetti/issues/298 I was able to reproduce your issue when using a DrawableShape and Alpha.

DanielMartinus commented 1 year ago

Fixes has been released in version 2.0.3, thanks for your contribution!