search

DanielMartinus / Konfetti

Celebrate more with this lightweight confetti particle system 🎊
ISC License
3.19k stars 301 forks source link

Replace withFrameMillis with withInfiniteAnimationFrameMillis to run … #333

Closed lupuuss closed 4 days ago

lupuuss commented 3 months ago

Closes #306

matthewbartos commented 4 days ago

@DanielMartinus can we merge this one?

DanielMartinus commented 4 days ago

@matthewbartos hey, thanks for tagging me. For sure, could you give me a little rundown on how this is fixing the issue?

matthewbartos commented 4 days ago

Please see work from @crowleysimon and @lupuuss - they claim that this change fixes failing UI tests:

Compose did not get idle after 48903 attempts in 60 SECONDS. Please check your measure/layout lambdas, they may be causing an infinite composition loop. Or set Espresso's master idling policy if you require a longer timeout. The following Idle Conditions failed .
androidx.test.espresso.AppNotIdleException
DanielMartinus commented 4 days ago

@matthewbartos let me check out that project later today 👍🏻

matthewbartos commented 4 days ago

Thank you @DanielMartinus - when do you anticipate the next release? 🙂

DanielMartinus commented 4 days ago

@matthewbartos I'm running into some issues publishing the release and need to set aside time to figure out exactly what's going on. Over the next few days, I'll try to schedule some time for that. I'll keep you updated here