search

DanielNT / ALTranslationCenter

Extension for improving speed in multilanguage developing with AL Language.
0 stars 0 forks source link

Error in PromotedActionCategories translations #5

Closed JavierFuentes closed 1 year ago

JavierFuentes commented 1 year ago

settings.json

{
    "alTranslationCenter.general.customLanguageMapping": {
      "ESP": "es-ES|es-ES_tradnl"
    }
}

PromotedActionCategories = 'New,Process,Report,Post/Print,Prepare,Line,Item,Item Availability by,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Registrar e imprimir,Preparar,Línea,Producto,Disponibilidad producto por,Modula"'

image

Could you check and fix it please?

DanielNT commented 1 year ago

Hi @JavierFuentes, I checked in a example project and it works (with the same settings.json).

page 50100 "Example"
{
    PageType = List;
    ApplicationArea = All;
    UsageCategory = Lists;
    SourceTable = "Customer";
    PromotedActionCategories = 'New,Process,Report,Post/Print,Prepare,Line,Item,Item Availability by,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Registrar e imprimir,Preparar,Línea,Producto,Disponibilidad producto por,Modula"';

I will check more later.

DanielNT commented 1 year ago

I created another page with exactly the same values, but I cannot replicate the issue.

page 50100 "Example"
{
    PageType = List;
    ApplicationArea = All;
    UsageCategory = Lists;
    SourceTable = "Customer";
    PromotedActionCategories = 'New,Process,Report,Post/Print,Prepare,Line,Item,Item Availability by,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Registrar e imprimir,Preparar,Línea,Producto,Disponibilidad producto por,Modula"';
}
page 50101 "Example 2"
{
    PageType = List;
    ApplicationArea = All;
    UsageCategory = Lists;
    SourceTable = "Customer";
    PromotedActionCategories = 'New,Process,Report,Post/Print,Prepare,Line,Item,Item Availability by,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Registrar e imprimir,Preparar,Línea,Producto,Disponibilidad producto por,Modula"';
}

settings.json

{
    "alTranslationCenter.general.customLanguageMapping": {
      "ESP": "es-ES|es-ES_tradnl"
    }
}

Could you share the source XLIFF (or only the part that triggers the error)?

JavierFuentes commented 1 year ago

Hi @DanielNT , we have reproduced the problem again.

I'll give you the extract of the .g.xlf file that references those text strings...

<?xml version="1.0" encoding="utf-8"?>
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
  <file datatype="xml" source-language="en-US" target-language="en-US" original="MODULA">
    <body>
      <group id="body">
        <trans-unit id="PageExtension 2183374251 - Property 2019332006" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>New,Process,Report,Release,Modula</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula"</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Property PromotedActionCategories</note>
        </trans-unit>
        <trans-unit id="PageExtension 2183374251 - Change 1587086413 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>Release</source>
          <!-- This line seems to fail -->
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 3.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_Category4 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2183374251 - Change 2224783030 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>Modula</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 4.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_Category5 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2183374251 - Change 278110413 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>New</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 0.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_New - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2183374251 - Change 3383493608 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>Process</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 1.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_Process - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2183374251 - Change 2234406979 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
          <source>Report</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 2.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_Report - Property Caption</note>
        </trans-unit>
      </group>
    </body>
  </file>
</xliff>
DanielNT commented 1 year ago

It seems that the XLIFF have a strange developer comment:

 <trans-unit id="PageExtension 2183374251 - Change 1587086413 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 1558066289">
     <source>Release</source>
          <!-- This line seems to fail -->
      <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 3.</note>
      <note from="Xliff Generator" annotates="general" priority="3">PageExtension MOD Warehouse Shipment List - Change Category_Category4 - Property Caption</note>
 </trans-unit>

The XML node with from="Developer", which is the base for the translation is:

ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 3.

instead of

ESP="Nuevo,Proceso,Informe,Lanzar,Modula"

So it triggers an error.

Something like this:

page 50100 "Example"
{
    PageType = List;
    ApplicationArea = All;
    UsageCategory = Lists;
    SourceTable = "Customer";
    PromotedActionCategories = 'New,Process,Report,Release,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Lanzar,Modula" - Generated from the PromotedActionCategories property index 3.';
}
JavierFuentes commented 1 year ago

Hi again @DanielNT , yes, this line seems to raise the error, but the - Generated from the PromotedActionCategories property index 3. sub-strings appear automatically for some reason using your extension...

DanielNT commented 1 year ago

Hi again @DanielNT , yes, this line seems to raise the error, but the - Generated from the PromotedActionCategories property index 3. sub-strings appear automatically for some reason using your extension...

The commands ATC: Package with translation or ATC: Publish with translation uses Microsoft AL Language internal functions, so apparently doesn't make sense.

Could you try this? 1) Backup the Translations Folder and source XLIFF. 2) Delete the folder and the source XLIFF. 3) Disable AL Translation Center. 4) Execute AL: Package. 5) Search for - Generated from the PromotedActionCategories property index 3.. 6) Have any occurrences?

If no, enable "Al Translation Center" and execute ATC: Generate Xliff translations from source, and check if it throws the same error. If it works, delete again the folder and source file, and execute ATC: Package with translation.

If yes, there is a constant/label/caption with some trouble or it's an error of the AL Language Extension.

JavierFuentes commented 1 year ago

Hi @DanielNT , this example throws the Error for us in 2 different laptops and projects...

pageextension 50001 "my_Transfer Order" extends "Transfer Order"
{
    PromotedActionCategories = 'New,Process,Report,Release,Posting,Order,Documents,Print/Send,Navigate,Modula', Comment = 'ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula"';

}

image

image

Could you check it please?

DanielNT commented 1 year ago

I've created a new project with your example (attached below -no .alpackages included-), and it works well. ALProjectJF.zip

Extensions:

Feel free to modify the example for adjusting to your issue and upload it. Check and compare versions of both extensions.

JavierFuentes commented 1 year ago

Hi again @DanielNT , when I change in your example from "runtime": "8.1" to "runtime": "11.0" (v22.1) the Error raises again.

ALProjectJF_target_110.zip

Could you check it please?

DanielNT commented 1 year ago

Hi again @DanielNT , when I change in your example from "runtime": "8.1" to "runtime": "11.0" (v22.1) the Error raises again.

ALProjectJF_target_110.zip

Could you check it please?

Thanks @JavierFuentes, now it's clear that changing from

Runtime 9.x

<?xml version="1.0" encoding="utf-8"?>
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
  <file datatype="xml" source-language="en-US" target-language="en-US" original="ALProjectJF">
    <body>
      <group id="body">
        <trans-unit id="PageExtension 2340498986 - Property 2019332006" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>New,Process,Report,Release,Posting,Order,Documents,Print/Send,Navigate,Modula</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula"</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Property PromotedActionCategories</note>
        </trans-unit>
      </group>
    </body>
  </file>
</xliff>

To Runtime 10.x or 11.x (with promoted actions using actionref syntax):

<?xml version="1.0" encoding="utf-8"?>
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
  <file datatype="xml" source-language="en-US" target-language="en-US" original="ALProjectJF">
    <body>
      <group id="body">
        <trans-unit id="PageExtension 2340498986 - Property 2019332006" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>New,Process,Report,Release,Posting,Order,Documents,Print/Send,Navigate,Modula</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula"</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Property PromotedActionCategories</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 3306084698 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Modula</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 9.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category10 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 1587086413 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Release</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 3.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category4 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 2224783030 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Posting</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 4.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category5 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 311693179 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Order</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 5.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category6 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 949389796 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Documents</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 6.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category7 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 2524661601 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Print/Send</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 7.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category8 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 3162358218 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Navigate</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 8.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Category9 - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 278110413 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>New</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 0.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_New - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 3383493608 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Process</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 1.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Process - Property Caption</note>
        </trans-unit>
        <trans-unit id="PageExtension 2340498986 - Change 2234406979 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" al-object-target="Page 66664215">
          <source>Report</source>
          <note from="Developer" annotates="general" priority="2">ESP="Nuevo,Proceso,Informe,Lanzar,Registrar,Pedido,Documentos,Imprimir y enviar,Navegar,Modula" - Generated from the PromotedActionCategories property index 2.</note>
          <note from="Xliff Generator" annotates="general" priority="3">PageExtension my_Transfer Order - Change Category_Report - Property Caption</note>
        </trans-unit>
      </group>
    </body>
  </file>
</xliff>

It changes the developer comments in the source file. I will check it.

DanielNT commented 1 year ago

@JavierFuentes can you test the version v2.2.0 and check if it fixes the issue?

JavierFuentes commented 1 year ago

Hi @DanielNT , it works ok!

Thank you very much for solving the problem so quickly.