DanielPhoton / xld

Automatically exported from code.google.com/p/xld
0 stars 0 forks source link

Make valid cue sheets from download track info (quotation marks, encoding, etc.) #34

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
In ripping a CD to flac + separate cue sheet, I used the feature where 
MusicBrainz etc. will be consulted for the track info, and had two problems 
with the resulting cue sheet:

* The track title info included quotation marks, e.g. Symphony #6 "Pastoral". 
This gives an invalid cue sheet, since you can't have quotation marks within 
the quotation marks of a track title. XLD should turn these to single quotes, 
perhaps.

* I was producing a utf8 cue sheet, but the track title info was in some other 
encoding. This resulted in some nonsense characters. It would be good if there 
were an option to specify the track title info's encoding, and XLD could then 
convert as it forms the cue sheet.

Original issue reported on code.google.com by mattne...@gmail.com on 21 Aug 2011 at 6:00

GoogleCodeExporter commented 8 years ago
About the double quotation in the cuesheet, XLD should read it without problem.

About the encoding issue, XLD assumes that the server returns UTF-8 characters 
(server always returns UTF-8 encoded texts, by its specification). So if you 
have odd characters in the cuesheet, that means you get wrongly submitted data 
from the server.

Original comment by tmkkmac on 21 Aug 2011 at 6:24

GoogleCodeExporter commented 8 years ago
any comments?

Original comment by tmkkmac on 2 Sep 2011 at 2:49

GoogleCodeExporter commented 8 years ago
Well, obviously I think you're mistaken on both counts. But that's fine; I can 
hand-tweak the cue sheet later to make it valid.

Original comment by mattne...@gmail.com on 2 Sep 2011 at 4:45

GoogleCodeExporter commented 8 years ago
mistaken?

Original comment by tmkkmac on 2 Sep 2011 at 6:50

GoogleCodeExporter commented 8 years ago
Sorry if I wasn't clear. Your comment 1 is a push-back indicating that my 
original report is flawed and that there is no defect to correct in XLD. I'm 
responding that I regard this as incorrect.

The fact is that in my normal workflow (put in a CD, get the metadata from an 
online database, rip to flac + cue) I am sometimes getting invalid cue sheets 
because the metadata is faulty (quotation marks in a track's title or incorrect 
encoding). Of course this is not the fault of XLD; it's the fault of the 
metadata database. But I'm suggesting that, since this *does* happen, instead 
of generating invalid cue sheets in this situation, XLD should provide the 
means to fix the problem and generate valid cue sheets.

You're implying that I'm wrong, and I'm disagreeing with you. But it's your 
software, so obviously you're perfectly free to ignore my suggestion and I can 
go on fixing the cue sheet by hand after XLD generates it.

Original comment by mattne...@gmail.com on 3 Sep 2011 at 1:18

GoogleCodeExporter commented 8 years ago
Well, XLD can correctly handle nested quotation marks in the cue sheet. So I 
cannot understand what is your problem with it. There is no specification that 
double quoted text should not include double quotation marks (it can be easily 
handled by longest match principle).

Original comment by tmkkmac on 3 Sep 2011 at 4:48

GoogleCodeExporter commented 8 years ago
I have observed that XLD has trouble with cuesheets and double-quotes (when 
creating them). I have taken to using single quotes anywhere I would otherwise 
have double-quotes, which can occasionally look ugly.

Original comment by wils...@gmail.com on 4 Sep 2011 at 6:02

GoogleCodeExporter commented 8 years ago
What trouble?

Original comment by tmkkmac on 4 Sep 2011 at 6:24

GoogleCodeExporter commented 8 years ago
For example, in foobar2000, a program that generally supports standards about 
as well as anybody:
could not enumerate tracks (Error parsing cuesheet: invalid TITLE syntax (line 
8)) on:
\\vmware-host\shared folders\XLD\FLAC\Tom Petty and the 
Heartbreakers\Doublequote Test-MFSL UDCD 565\Doublequote Test-MFSL UDCD 565.cue
Attached is an example (added some quotes to an album I happened to have 
sitting around).

Original comment by wils...@gmail.com on 4 Sep 2011 at 6:40

Attachments:

GoogleCodeExporter commented 8 years ago
I don't think that is an issue. See my opinion in the comment 6.

Original comment by tmkkmac on 4 Sep 2011 at 6:45