search

DanielRiera / estimated-delivery-woocommerce

8 stars 6 forks source link

Working days #41

Closed fouli86 closed 1 year ago

fouli86 commented 1 year ago

Hello,

I was wandering if you could add besides the days that NO shipments are made, also the working days. In my case, deliveries take between 4-10 working days, so the calculation is wrong.

Thanks anyway for this product.

Kind regards, Fay

DanielRiera commented 1 year ago

Hi thank you for opening this, can you explain what you need?

fouli86 commented 1 year ago

Hello,

Thank you for the immediate response. The extension only takes account the days that no shipments are made, not the working days in general. I tell my customers that the estimate delivery is between 4-10 working days (working days are Monday to Friday), which is maximum 2 weeks time. I set "Days for Delivery" to 4, the "Max Days for Delivery" to 10 and "Maximum Time" to 15:00, but the extension doesn't calculate the days correctly. It shows a range between 3 working days and 10 days, including the weekend that no shipments are made. More specifically, at the moment it is the 4th of May, 20:42. The range should have been between 10-18 May, but it is 9-15 May. I wish I could explain it better, but i think it would help to see for yourself. Do you have any suggestion on how to set the days in a better way?

Thanks in advance

Kind regards, Fay

From: Daniel Riera @.> Sent: Wednesday, May 3, 2023 4:12 AM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Author @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

Hi thank you for opening this, can you explain what you need?

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1532336384, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWDM2FIIBPA3EIKBMMTXEGWIDANCNFSM6AAAAAAXRXIRCE. You are receiving this because you authored the thread.Message ID: @.***>

DanielRiera commented 1 year ago

You can check timezone on wordpress settings?

Can you check what date and time is shown in the maximum time? (On field description) now: .....

Regards

fouli86 commented 1 year ago

I tried with multiple values, nothing changed. The maximum time is correct: (Server time) HH:mm now is 2023-05-04 22:38.

Kind regards, Fay

From: Daniel Riera @.> Sent: Thursday, May 4, 2023 8:48 PM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Author @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

You can check timezone on wordpress settings?

Can you check what date and time is shown in the maximum time? (On field description) now: .....

Regards

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1535172603, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWEEWY24JLYBGS3DAADXEPTV3ANCNFSM6AAAAAAXRXIRCE. You are receiving this because you authored the thread.Message ID: @.***>

DanielRiera commented 1 year ago

Can you send me global plugin configuration?

fouli86 commented 1 year ago

Hello,

Let's see:

Kind regards, Fay

From: Daniel Riera @.> Sent: Thursday, May 4, 2023 10:54 PM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Author @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

Can you send me global plugin configuration?

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1535332119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWFK4HEE7I3UMB6V6TDXEQCNRANCNFSM6AAAAAAXRXIRCE. You are receiving this because you authored the thread.Message ID: @.***>

Hello

DanielRiera commented 1 year ago

Hi @fouli86 ! You can try this.

Download plugin by this link, is a branch and try if is correct, check your Time Max, i saw an error on my side.

ISSUE41 BRANCH

Regards, if is correct post a message for update plugin :)

fouli86 commented 1 year ago

Hello!

The 4-10 working days combination works like a charm, the 1-3 working days combination counts from tomorrow (it is Sunday, a day that no shipments are made) but shows correctly the third working day. More specifically, it should show 8-10 May, but it shows 7-10 May.

Kind regards, Fay

From: Daniel Riera @.> Sent: Friday, May 5, 2023 7:26 PM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Mention @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

Hi @fouli86https://github.com/fouli86 ! You can try this.

Download plugin by this link, is a branch and try if is correct, check your Time Max, i saw an error on my side.

ISSUE41 BRANCHhttps://github.com/DanielRiera/estimated-delivery-woocommerce/archive/refs/heads/issue41.zip

Regards, if is correct post a message for update plugin :)

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1536493602, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWE7BYTWG35O74FARP3XEUS2LANCNFSM6AAAAAAXRXIRCE. You are receiving this because you were mentioned.Message ID: @.***>

DanielRiera commented 1 year ago

Hi @fouli86 !, you can download again on this branch and test again, sorry for this.

Issue 41

fouli86 commented 1 year ago

Hello,

Sorry for this but it is still not working properly. At the moment, it is past Maximum Time (it is set to 12:30PM), the combination 1-3 working days shows 9-10 May, (it should have been 9-11 May), and the combination 4-10 days shows 13-19 May (it should have been 12-22 May). The 13th of May is Saturday, we do not make shipments on Saturday.

Kind regards, Fay

From: Daniel Riera @.> Sent: Saturday, May 6, 2023 6:26 PM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Mention @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

Hi @fouli86https://github.com/fouli86 !, you can download again on this branch and test again, sorry for this.

Issue 41https://github.com/DanielRiera/estimated-delivery-woocommerce/archive/refs/heads/issue41.zip

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1537164715, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWD6ETLLEY7INIYARZLXEZUQ5ANCNFSM6AAAAAAXRXIRCE. You are receiving this because you were mentioned.Message ID: @.***>

DanielRiera commented 1 year ago

Sorry for this, thanks for test, i working on this, don´t have much free time.

fouli86 commented 1 year ago

Hello,

You are kind enough to work on it, so please take your time and I am available to test again whenever you are ready.

Kind regards, Fay

From: Daniel Riera @.> Sent: Thursday, May 11, 2023 2:04 AM To: DanielRiera/estimated-delivery-woocommerce @.> Cc: fouli86 @.>; Mention @.> Subject: Re: [DanielRiera/estimated-delivery-woocommerce] Working days (Issue #41)

Sorry for this, thanks for test, i working on this, don´t have much free time.

— Reply to this email directly, view it on GitHubhttps://github.com/DanielRiera/estimated-delivery-woocommerce/issues/41#issuecomment-1542915768, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJXBWFEM7Q2XXJ5GZK6WXTXFQNI7ANCNFSM6AAAAAAXRXIRCE. You are receiving this because you were mentioned.Message ID: @.***>

DanielRiera commented 1 year ago

Hi @fouli86

You can download new version from WordPress plugin repository, i updated with @elrosa PR.

Thanks and sorry for delay